xfs
[Top] [All Lists]

Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support v9

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support v9
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 10 May 2012 15:07:24 -0500
Cc: jeff.liu@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120510200832.GP16881@xxxxxxx>
References: <4FABC2AD.2030609@xxxxxxxxxx> <4FAC1C33.5050508@xxxxxxx> <20120510200832.GP16881@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 05/10/12 15:08, Ben Myers wrote:
On Thu, May 10, 2012 at 02:51:15PM -0500, Mark Tinguely wrote:
On 05/10/12 08:29, Jeff Liu wrote:
Hello,

This is the revised patch according to Mark's comments.
Is it possible to get it to accept if there are no other issues,
so that I can continue to work on the unwritten part based on that.

Thanks,
-Jeff

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>

---

+
+STATIC loff_t
+xfs_seek_hole(
+       struct file             *file,
+       loff_t                  start,
+       u32                     type)
+{
+       struct inode            *inode = file->f_mapping->host;
+       struct xfs_inode        *ip = XFS_I(inode);
+       struct xfs_mount        *mp = ip->i_mount;
+       loff_t                  uninitialized_var(offset);
+       loff_t                  holeoff;
+       xfs_fsize_t             isize;
+       xfs_fileoff_t           fsbno;
+       uint                    lock;
+       int                     error;
+
+       if (XFS_FORCED_SHUTDOWN(mp))
+               return -XFS_ERROR(EIO);

I think xfs_bmapi_read() returns just a XFS_ERROR(EIO), not negative.
Ben can fix up if you agree.

Looks like error is negated at the bottom of the function and is not a problem.


Yes, but xfs_seek_data() also negates at the error at the end of the routine. They should be consistent.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>