xfs
[Top] [All Lists]

Re: [PATCH 6/3] xfs: make largest supported offset less shouty

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/3] xfs: make largest supported offset less shouty
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 9 May 2012 14:14:13 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120508224330.GK5091@dastard>
References: <1335519922-14371-1-git-send-email-david@xxxxxxxxxxxxx> <20120429125729.GU9541@dastard> <20120508181540.GN16881@xxxxxxx> <20120508224330.GK5091@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, May 09, 2012 at 08:43:30AM +1000, Dave Chinner wrote:
> On Tue, May 08, 2012 at 01:15:40PM -0500, Ben Myers wrote:
> > On Sun, Apr 29, 2012 at 10:57:29PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
> > > XFS_MAXIOFFSET() is just a simple macro that resolves to
> > > mp->m_maxioffset. It doesn't need to exist, and it just makes the
> > > code unnecessarily loud and shouty.
> > > 
> > > Make it quiet and easy to read.
> > 
> > Yep, looks good.
> > 
> > Reviewed-by: Ben Myers <bpm@xxxxxxx>
> 
> I've got new versions that use s_maxbytes whih I need to post....

Ok, I'll hold off on this one.

<Prev in Thread] Current Thread [Next in Thread>