xfs
[Top] [All Lists]

Re: [RFC v5 PATCH 3/4] xfs: Add pquotaino to on-disk super block

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [RFC v5 PATCH 3/4] xfs: Add pquotaino to on-disk super block
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 4 May 2012 14:52:24 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120314202641.17044.32835.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20120314202623.17044.90045.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120314202641.17044.32835.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Mar 14, 2012 at 03:26:42PM -0500, Chandra Seetharaman wrote:
> @@ -1055,19 +1057,22 @@ xfs_qm_qino_alloc(
>               ASSERT((sbfields & (XFS_SB_VERSIONNUM | XFS_SB_UQUOTINO |
>                                  XFS_SB_GQUOTINO | XFS_SB_QFLAGS)) ==
>                      (XFS_SB_VERSIONNUM | XFS_SB_UQUOTINO |
> -                     XFS_SB_GQUOTINO | XFS_SB_QFLAGS));
> +                     XFS_SB_GQUOTINO | XFS_SB_PQUOTINO | XFS_SB_QFLAGS));

I popped this assert in my testing.  I think it should look like this:

Index: xfs/fs/xfs/xfs_qm.c
===================================================================
--- xfs.orig/fs/xfs/xfs_qm.c
+++ xfs/fs/xfs/xfs_qm.c
@@ -838,7 +838,8 @@ xfs_qm_qino_alloc(
        if (flags & XFS_QMOPT_SBVERSION) {
                ASSERT(!xfs_sb_version_hasquota(&mp->m_sb));
                ASSERT((sbfields & (XFS_SB_VERSIONNUM | XFS_SB_UQUOTINO |
-                                  XFS_SB_GQUOTINO | XFS_SB_QFLAGS)) ==
+                                  XFS_SB_GQUOTINO | XFS_SB_PQUOTINO |
+                                  XFS_SB_QFLAGS)) ==
                       (XFS_SB_VERSIONNUM | XFS_SB_UQUOTINO |
                        XFS_SB_GQUOTINO | XFS_SB_PQUOTINO | XFS_SB_QFLAGS));

-Ben

<Prev in Thread] Current Thread [Next in Thread>