xfs
[Top] [All Lists]

Re: [PATCH 10/10] xfs: factor buffer reading from xfs_dir2_leaf_getdents

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/10] xfs: factor buffer reading from xfs_dir2_leaf_getdents
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 04 May 2012 07:42:27 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335249220-22274-11-git-send-email-david@xxxxxxxxxxxxx>
References: <1335249220-22274-1-git-send-email-david@xxxxxxxxxxxxx> <1335249220-22274-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/24/12 01:33, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The buffer reading code in xfs_dir2_leaf_getdents is complex and difficult to
follow due to the readahead and all the context is carries. it is also badly
indented and so difficult to read. Factor it out into a separate function to
make it easier to understand and optimise in future patches.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good.


Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 10/10] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Mark Tinguely <=