xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfsprogs: Remove incore use of XFS_OQUOTA_ENFD and XFS_O

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 1/4] xfsprogs: Remove incore use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Thu, 03 May 2012 15:26:17 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120503200457.GQ16881@xxxxxxx>
Organization: IBM
References: <20120123173243.31735.37262.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120123173249.31735.17660.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120503200457.GQ16881@xxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
On Thu, 2012-05-03 at 15:04 -0500, Ben Myers wrote:
> On Mon, Jan 23, 2012 at 11:32:49AM -0600, Chandra Seetharaman wrote:
> > >From ba28fc49821079a734f24af05671155f6b32b20c Mon Sep 17 00:00:00 2001
> > From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
> > Date: Tue, 13 Dec 2011 15:55:34 -0600
> > Subject: [PATCH 1/4] Remove incore use of XFS_OQUOTA_ENFD and 
> > XFS_OQUOTA_CHKD. Instead,
> >  start using XFS_GQUOTA_.* XFS_PQUOTA_.* counterparts.
> > 
> > No changes is made to the on-disk version of the superblock yet. On-disk
>              are                                                 The 
> 
will fix
 
> > copy still uses XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD.
> <

<snip>
> >  
> > +static inline int xfs_sb_version_hasnooquota(xfs_sb_t *sbp)
> 
> IIRC, in the kernel you used xfs_sb_version_has_no_oquota.  I think you should
> use the same name in xfsprogs.

yes, will fix.
> 
> > +{
> > +   return xfs_sb_version_hasmorebits(sbp) &&
> > +           (sbp->sb_features2 & XFS_SB_VERSION2_NO_OQUOTA);
> > +}
> > +
> > +static inline void xfs_sb_version_addnooquota(xfs_sb_t *sbp)
> > +{
> > +   sbp->sb_versionnum |= XFS_SB_VERSION_MOREBITSBIT;
> > +   sbp->sb_features2 |= XFS_SB_VERSION2_PROJID32BIT;
> 
> I'm not sure about this.  I don't think addnooquota necessarily implies a 32
> bit project id.  What say you?

It is cut-n-paste issue, it should be XFS_SB_VERSION2_NO_OQUOTA
will fix it.
> 
> Else, the patch looks pretty good.
> 
> -Ben
> 


<Prev in Thread] Current Thread [Next in Thread>