Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs

xfs

Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Mon, 30 Apr 2012 12:38:21 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120429215420.GL19889@xxxxxxxxxxxxx>
References:	<1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-34-git-send-email-david@xxxxxxxxxxxxx> <20120429215420.GL19889@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sun, Apr 29, 2012 at 05:54:20PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 23, 2012 at 03:59:03PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > xfs-do-force_shutdown now is the only thing in xfs_rw.c. There is no
> > need to keep it in it's own file anymore, so move it to xfs_fsops.c
> > next to xfs_fs_goingdown() and kill xfs_rw.c.
> 
> To me xfs_mount.c seems like the more reasonable place.

It is not used in userspace, so rather than place it in a file that
userspace shares (xfs_mount.c) and have to deal with that every
merge, I moved it to a file that is not shared with userspace.
Placing it with other shutdown code (xfs_fs_goingdown()) seemed like
a reasonable thing to do...

> Either way killing xfs_rw.c is a good thing.

*nod*

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 14/37] xfs: Use preallocation for inodes with extsz hints, (continued) [PATCH 14/37] xfs: Use preallocation for inodes with extsz hints, Dave Chinner Re: [PATCH 14/37] xfs: Use preallocation for inodes with extsz hints, Christoph Hellwig [PATCH 13/37] xfs: page type check in writeback only checks last buffer, Dave Chinner [PATCH 20/37] xfs: kill b_file_offset, Dave Chinner [PATCH 23/37] xfs: kill xfs_buf_btoc, Dave Chinner [PATCH 21/37] xfs: use blocks for counting length of buffers, Dave Chinner [PATCH 22/37] xfs: use blocks for storing the desired IO size, Dave Chinner [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c, Dave Chinner Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c, Mark Tinguely Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c, Christoph Hellwig Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c, Dave Chinner <= [PATCH 09/37] xfs: on-stack delayed write buffer lists, Dave Chinner Re: [PATCH 09/37] xfs: on-stack delayed write buffer lists, Mark Tinguely Re: [PATCH 09/37] xfs: on-stack delayed write buffer lists, Christoph Hellwig [PATCH 19/37] xfs: clean up buffer get/read call API, Dave Chinner [PATCH 24/37] xfs: kill XBF_LOCK, Dave Chinner [PATCH 25/37] xfs: kill xfs_read_buf(), Dave Chinner [PATCH 27/37] xfs: use iolock on XFS_IOC_ALLOCSP calls, Dave Chinner [PATCH 30/37] xfs: clean up busy extent naming, Dave Chinner Re: [PATCH 30/37] xfs: clean up busy extent naming, Mark Tinguely [PATCH 30/37 V2] xfs: clean up busy extent naming, Dave Chinner

Previous by Date:	Re: [PATCH 31/37] xfs: move xfs_fsb_to_db to xfs_bmap.h, Dave Chinner
Next by Date:	Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour, Dave Chinner
Previous by Thread:	Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c, Christoph Hellwig
Next by Thread:	[PATCH 09/37] xfs: on-stack delayed write buffer lists, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]