xfs
[Top] [All Lists]

Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 30 Apr 2012 12:38:21 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120429215420.GL19889@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-34-git-send-email-david@xxxxxxxxxxxxx> <20120429215420.GL19889@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Apr 29, 2012 at 05:54:20PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 23, 2012 at 03:59:03PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > xfs-do-force_shutdown now is the only thing in xfs_rw.c. There is no
> > need to keep it in it's own file anymore, so move it to xfs_fsops.c
> > next to xfs_fs_goingdown() and kill xfs_rw.c.
> 
> To me xfs_mount.c seems like the more reasonable place.

It is not used in userspace, so rather than place it in a file that
userspace shares (xfs_mount.c) and have to deal with that every
merge, I moved it to a file that is not shared with userspace.
Placing it with other shutdown code (xfs_fs_goingdown()) seemed like
a reasonable thing to do...

> Either way killing xfs_rw.c is a good thing.

*nod*

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>