xfs
[Top] [All Lists]

Re: [PATCH 29/37 V3] xfs: move busy extent handling to it's own file

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 29/37 V3] xfs: move busy extent handling to it's own file
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 30 Apr 2012 12:17:27 +1000
Cc: Ben Myers <bpm@xxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120430003628.GC3283@dastard>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-30-git-send-email-david@xxxxxxxxxxxxx> <20120423175725.GG16881@xxxxxxx> <20120424002502.GS9541@dastard> <4F96CD24.2070805@xxxxxxx> <4F96EC97.3050404@xxxxxxx> <20120429103943.GQ9541@dastard> <20120429215027.GH19889@xxxxxxxxxxxxx> <20120430003628.GC3283@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 30, 2012 at 10:36:28AM +1000, Dave Chinner wrote:
> On Sun, Apr 29, 2012 at 05:50:27PM -0400, Christoph Hellwig wrote:
> > I would have called it xfs_busy_extent.h, but given how far you are with
> > the series it's really not worth bike sheeding about this detail.
> 
> I'm ambivalent, really. I used extent_busy to match the
> xfs_extfree_item.c naming. i.e. extent specific manipulations are in
> xfs_ext* namespace. It's pretty simple to change (a couple of search
> and replace), so if you'd prefer busy_extent I can change it pretty
> quickly...

Actually, I just found a problem with this patch -
xfs_alloc_busy_trim is not properly handled - so I've got to respin
it. I'll change it all to busy_extent while I'm at it...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>