Re: [PATCH 6/3] xfs: make largest supported offset less shouty

xfs

Re: [PATCH 6/3] xfs: make largest supported offset less shouty

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 6/3] xfs: make largest supported offset less shouty
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 29 Apr 2012 17:58:30 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120429125729.GU9541@dastard>
References:	<1335519922-14371-1-git-send-email-david@xxxxxxxxxxxxx> <20120429125729.GU9541@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sun, Apr 29, 2012 at 10:57:29PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> XFS_MAXIOFFSET() is just a simple macro that resolves to
> mp->m_maxioffset. It doesn't need to exist, and it just makes the
> code unnecessarily loud and shouty.
> 
> Make it quiet and easy to read.

Do we actually need to keep around a value in our superblock?
s_maxbytes in the VFS superblock already does this, and it seems like
at least our checks in the read path are superflous.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/3] xfs: failed writes and stale delalloc blocks., Dave Chinner [PATCH 2/3] xfs: punch new delalloc blocks out of failed writes inside EOF., Dave Chinner [PATCH 1/3] xfs: punch all delalloc blocks beyond EOF on write failure., Dave Chinner [PATCH 3/3] xfs: prevent needless mount warning causing test failures, Dave Chinner [PATCH 4/3] xfs: don't assert on delalloc regions beyond EOF, Dave Chinner [PATCH 5/3] xfs: limit specualtive delalloc to maxioffset, Dave Chinner [PATCH 6/3] xfs: make largest supported offset less shouty, Dave Chinner Re: [PATCH 6/3] xfs: make largest supported offset less shouty, Christoph Hellwig <= Re: [PATCH 6/3] xfs: make largest supported offset less shouty, Dave Chinner Re: [PATCH 6/3] xfs: make largest supported offset less shouty, Dave Chinner

Previous by Date:	Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour, Christoph Hellwig
Next by Date:	Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Dave Chinner
Previous by Thread:	[PATCH 6/3] xfs: make largest supported offset less shouty, Dave Chinner
Next by Thread:	Re: [PATCH 6/3] xfs: make largest supported offset less shouty, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]