xfs
[Top] [All Lists]

Re: [PATCH 6/3] xfs: make largest supported offset less shouty

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/3] xfs: make largest supported offset less shouty
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 29 Apr 2012 17:58:30 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120429125729.GU9541@dastard>
References: <1335519922-14371-1-git-send-email-david@xxxxxxxxxxxxx> <20120429125729.GU9541@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Apr 29, 2012 at 10:57:29PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> XFS_MAXIOFFSET() is just a simple macro that resolves to
> mp->m_maxioffset. It doesn't need to exist, and it just makes the
> code unnecessarily loud and shouty.
> 
> Make it quiet and easy to read.

Do we actually need to keep around a value in our superblock?
s_maxbytes in the VFS superblock already does this, and it seems like
at least our checks in the read path are superflous.

<Prev in Thread] Current Thread [Next in Thread>