| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 29 Apr 2012 17:57:28 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1335160747-17254-38-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-38-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> @@ -399,8 +399,9 @@ _xfs_buf_map_pages(
> if (bp->b_page_count == 1) {
> /* A single page buffer is always mappable */
> bp->b_addr = page_address(bp->b_pages[0]) + bp->b_offset;
> - bp->b_flags |= XBF_MAPPED;
> - } else if (flags & XBF_MAPPED) {
> + } else if (flags & XBF_UNMAPPED) {
> + bp->b_addr = NULL;
Do we need this explicit assigned? The buffer should always have
b_addr == NULL at this point.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| Previous by Date: | Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 6/3] xfs: make largest supported offset less shouty, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour, Dave Chinner |
| Next by Thread: | Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |