xfs
[Top] [All Lists]

Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 29 Apr 2012 17:55:55 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335160747-17254-37-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-37-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 23, 2012 at 03:59:06PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When we fail to mount the log in xfs_mountfs(), we tear down all the
> infrastructure we have already allocated. However, the process of
> mounting the log may have progressed to the point of reading,
> caching and modifying buffers in memory. Hence before we can free
> all the infrastructure, we have to flush and remove all the buffers
> from memory.
> 
> Problem first reported by Eric Sandeen, later a different incarnation
> was reported by Ben Myers.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>