xfs
[Top] [All Lists]

Re: [PATCH 35/37] xfs: Properly exclude IO type flags from buffer flags

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 35/37] xfs: Properly exclude IO type flags from buffer flags
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 29 Apr 2012 17:55:41 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335160747-17254-36-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-36-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 23, 2012 at 03:59:05PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Recent event tracing during a debugging session showed that flags
> that define the IO type for a buffer are leaking into the flags on
> the buffer incorrectly. Fix the flag exclusion mask in
> xfs_buf_alloc() to avoid problems that may be caused by such
> leakage.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>