xfs
[Top] [All Lists]

Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 29 Apr 2012 17:55:25 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335160747-17254-35-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-35-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
>   * Visible inode allocation functions.
>   */
> +/*
> + * Find a free (set) bit in the inode bitmask.
> + */
> +static inline int xfs_ialloc_find_free(xfs_inofree_t *fp)
> +{
> +     return xfs_lowbit64(*fp);
> +}

I'd suggest killing this helper entirely - there is just a single
caller, and using the lowbit helper directly actually is even more
obvious.

<Prev in Thread] Current Thread [Next in Thread>