Re: [PATCH 04/18] xfs: page type check in writeback only checks last buf

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 29 Apr 2012 17:39:26 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1334319061-12968-5-git-send-email-david@xxxxxxxxxxxxx>
References:	<1334319061-12968-1-git-send-email-david@xxxxxxxxxxxxx> <1334319061-12968-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Apr 13, 2012 at 10:10:47PM +1000, Dave Chinner wrote:
> The problem was first noticed by Peter Watkins.

Was this a user visible bug?  Do we have a test case for it?

Either way, the patch looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/18] xfs: current patch queue, Dave Chinner [PATCH 01/18] xfs: Ensure inode reclaim can run during quotacheck, Dave Chinner Re: [PATCH 01/18] xfs: Ensure inode reclaim can run during quotacheck, Mark Tinguely Re: [PATCH 01/18] xfs: Ensure inode reclaim can run during quotacheck, Christoph Hellwig [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Dave Chinner Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Mark Tinguely Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Christoph Hellwig <= Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Dave Chinner [PATCH 02/18] xfs: pass shutdown method into xfs_trans_ail_delete_bulk, Dave Chinner Re: [PATCH 02/18] xfs: pass shutdown method into xfs_trans_ail_delete_bulk, Mark Tinguely Re: [PATCH 02/18] xfs: pass shutdown method into xfs_trans_ail_delete_bulk, Dave Chinner [PATCH 02/18 V2] xfs: pass shutdown method into xfs_trans_ail_delete_bulk, Dave Chinner Re: [PATCH 02/18 V2] xfs: pass shutdown method into xfs_trans_ail_delete_bulk, Mark Tinguely [PATCH 06/18] xfs: fix buffer lookup race on allocation failure, Dave Chinner Re: [PATCH 06/18] xfs: fix buffer lookup race on allocation failure, Mark Tinguely [PATCH 05/18] xfs: Use preallocation for inodes with extsz hints, Dave Chinner Re: [PATCH 05/18] xfs: Use preallocation for inodes with extsz hints, Mark Tinguely

Previous by Date:	Re: [PATCH 01/18] xfs: Ensure inode reclaim can run during quotacheck, Christoph Hellwig
Next by Date:	Re: [PATCH 04/37] xfs: implement freezing by emptying the AIL, Christoph Hellwig
Previous by Thread:	Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Mark Tinguely
Next by Thread:	Re: [PATCH 04/18] xfs: page type check in writeback only checks last buffer, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]