xfs
[Top] [All Lists]

Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 23 Apr 2012 10:47:36 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335160747-17254-37-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-37-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/23/12 00:59, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

When we fail to mount the log in xfs_mountfs(), we tear down all the
infrastructure we have already allocated. However, the process of
mounting the log may have progressed to the point of reading,
caching and modifying buffers in memory. Hence before we can free
all the infrastructure, we have to flush and remove all the buffers
from memory.

Problem first reported by Eric Sandeen, later a different incarnation
was reported by Ben Myers.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>