xfs
[Top] [All Lists]

Re: [PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a sh

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a shutdown
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 23 Apr 2012 10:39:48 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1335160747-17254-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/23/12 00:58, Dave Chinner wrote:
From: Christoph Hellwig<hch@xxxxxxxxxxxxx>

If a filesystem has been forced shutdown we are never going to write inodes
to disk, which means the inode items will stay in the AIL until we free
the inode. Currently that is not a problem, but a pending change requires us
to empty the AIL before shutting down the filesystem. In that case leaving
the inode in the AIL is lethal. Make sure to remove the log item from the AIL
to allow emptying the AIL on shutdown filesystems.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>
Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>