xfs
[Top] [All Lists]

[PATCH 18/37] xfs: use kmem_zone_zalloc for buffers

To: xfs@xxxxxxxxxxx
Subject: [PATCH 18/37] xfs: use kmem_zone_zalloc for buffers
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 23 Apr 2012 15:58:48 +1000
In-reply-to: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

To replace the alloc/memset pair.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
---
 fs/xfs/xfs_buf.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index ddfc58f..f463dce 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -178,7 +178,7 @@ xfs_buf_alloc(
 {
        struct xfs_buf          *bp;
 
-       bp = kmem_zone_alloc(xfs_buf_zone, xb_to_km(flags));
+       bp = kmem_zone_zalloc(xfs_buf_zone, xb_to_km(flags));
        if (unlikely(!bp))
                return NULL;
 
@@ -187,7 +187,6 @@ xfs_buf_alloc(
         */
        flags &= ~(XBF_LOCK|XBF_MAPPED|XBF_DONT_BLOCK|XBF_READ_AHEAD);
 
-       memset(bp, 0, sizeof(xfs_buf_t));
        atomic_set(&bp->b_hold, 1);
        atomic_set(&bp->b_lru_ref, 1);
        init_completion(&bp->b_iowait);
-- 
1.7.9.5

<Prev in Thread] Current Thread [Next in Thread>