xfs
[Top] [All Lists]

Re: [PATCH 2/3 V2] xfstests 198, 240, common.rc: added check for aiodio-

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 2/3 V2] xfstests 198, 240, common.rc: added check for aiodio-sparse2
From: Tom Marek <tmarek@xxxxxxxxxx>
Date: Thu, 19 Apr 2012 15:53:25 +0200
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, dchinner@xxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1204191029220.4508@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <y> <1334654687-25450-1-git-send-email-tmarek@xxxxxxxxxx> <1334654687-25450-2-git-send-email-tmarek@xxxxxxxxxx> <20120418235135.GS6734@dastard> <alpine.LFD.2.00.1204191029220.4508@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
On 04/19/2012 10:32 AM, Lukas Czerner wrote:
On Thu, 19 Apr 2012, Dave Chinner wrote:

On Tue, Apr 17, 2012 at 11:24:46AM +0200, Tom Marek wrote:
Tests number 198 and 240 could fail when aiodio-sparse2 was not build.
_require_aiodio helper was added to common.rc file to fix this.

Cc: david@xxxxxxxxxxxxx
Signed-off-by: Tom Marek<tmarek@xxxxxxxxxx>
Reviewed-by: Lukas Czerner<lczerner@xxxxxxxxxx>
.....
@@ -770,6 +770,14 @@ _require_scratch()
      fi
  }

+# this test needs aio-dio-regress to be built
+#
+_require_aiodio()
+{
+    [ -x $here/src/aio-dio-regress/aiodio_sparse2 ] || \
+        _notrun "This tests requires src/aio-dio-regress/ to be built"
+}
This function already exists in common.rc, which is why I pointed it
out for use.

# this test requires that a (specified) aio-dio executable exists
# $1 - command (optional)
#
_require_aiodio()
{
     if [ -z "$1" ]
     then
         AIO_TEST=src/aio-dio-regress/aiodio_sparse2
         [ -x $AIO_TEST ] || _notrun "aio-dio utilities required"
     else
         AIO_TEST=src/aio-dio-regress/$1
         [ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
     fi
}

Cheers,

Dave.
Hi Tom,

did you use the git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
repository for the xfstests ? The one I've been using (from
oss.sgi.com) is terribly out of date so it does not have
_require_aiodio() yet.

Thanks!
-Lukas
Hi Lukas,

unfortunately I was using that old repository on oos.sgi.com.
Thanks!

T.

<Prev in Thread] Current Thread [Next in Thread>