[Top] [All Lists]

Re: [PATCH 1/3 V2] xfstests 233: fix user fsgqa access to fsstress

To: Tom Marek <tmarek@xxxxxxxxxx>
Subject: Re: [PATCH 1/3 V2] xfstests 233: fix user fsgqa access to fsstress
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 19 Apr 2012 10:01:41 +1000
Cc: xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx, dchinner@xxxxxxxxxx
In-reply-to: <1334654687-25450-1-git-send-email-tmarek@xxxxxxxxxx>
References: <y> <1334654687-25450-1-git-send-email-tmarek@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 17, 2012 at 11:24:45AM +0200, Tom Marek wrote:
> User fsgqa may sometimes be unable to run fsstress (when xfstests are owned by
> root) because fsgqa doesn't have rights to list directory where the fsstress
> utility is located.

That sounds like an installation problem, not something that needs
to be worked around in the tests. Indeed, this problem woul dmean
that the fsgqa user woul dnot be able to execute anything in the
src/, ltp/ or tools/ subdirectories, and I don't think we want to
work around all those sorts of problems in tests like this.

Indeed, if you look at the make install rules, the install rule for
the ltp/ subdir does:

TARGETS = doio fsstress fsx growfiles iogen
SCRIPTS = rwtest.sh
install: default
        $(INSTALL) -m 755 -d $(PKG_LIB_DIR)/ltp
        $(INSTALL) -m 755 $(TARGETS) $(PKG_LIB_DIR)/ltp
        $(INSTALL) -m 755 $(SCRIPTS) $(PKG_LIB_DIR)/ltp

It changes the permissions on the ltp/ directory to rwxr-xr-x, as
well as for the binaries in the ltp/ subdir. This means the fsgqa
user should be able to run the ltp/fsstress binary without any
changes to the test scripts.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>