xfs
[Top] [All Lists]

Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 18 Apr 2012 16:11:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327164646.158577302@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164646.158577302@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/27/12 11:44, Christoph Hellwig wrote:
Instead of writing the buffer directly from inside xfs_qm_dqflush return it
to the caller and let the caller decide what to do with the buffer.  Also
remove the pincount check in xfs_qm_dqflush that all non-blocking callers
already implement and the now unused flags parameter and the XFS_DQ_IS_DIRTY
check that all callers already perform.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

---
Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>