xfs
[Top] [All Lists]

Re: [PATCH 08/10] xfs: do not add buffers to the delwri queue until push

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] xfs: do not add buffers to the delwri queue until pushed
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 18 Apr 2012 16:11:28 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327164646.539031348@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164646.539031348@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/27/12 11:44, Christoph Hellwig wrote:
Instead of adding buffers to the delwri list as soon as they are logged,
even if they can't be written until commited because they are pinned
defer adding them to the delwri list until xfsaild pushes them.  This
makes the code more similar to other log items and prepares for writing
buffers directly from xfsaild.

The complication here is that we need to fail buffers that were added
but not logged yet in xfs_buf_item_unpin, borrowing code from
xfs_bioerror.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>