Re: [PATCH 06/10] xfs: do not write the buffer from xfs

xfs

Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Wed, 18 Apr 2012 08:33:16 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120327164645.870931834@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164645.870931834@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 03/27/12 11:44, Christoph Hellwig wrote:

Instead of writing the buffer directly from inside xfs_iflush return it to
the caller and let the caller decide what to do with the buffer.  Also
remove the pincount check in xfs_iflush that all non-blocking callers already
implement and the now unused flags parameter.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good,

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Dave Chinner Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Mark Tinguely <=

Previous by Date:	Re: [PATCH 04/10] xfs: implement freezing by emptying the AIL, Mark Tinguely
Next by Date:	task blocked for more than 120 seconds, Josef 'Jeff' Sipek
Previous by Thread:	Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Dave Chinner
Next by Thread:	Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]