Re: [RFC]xfs: using GFP_NOFS for blkdev_issue_flush

[Mark Tinguely <tinguely@xxxxxxx>]

On 04/16/12 01:58, Shaohua Li wrote:

> flush request is issued in transaction commit code path usually, so
> looks using
> GFP_KERNEL to allocate memory for flush request bio falls into the classic
> deadlock issue (memory reclaim recursion). Use GFP_NOFS to avoid recursion
> from reclaim context. Per Dave Chinner, there is only blkdev_issue_flush
> might
> be buggy here. But using GFP_NOFS by default for all calls should not
> matter.
>
> Signed-off-by: Shaohua Li <shli@xxxxxxxxxxxx>
> ---

Looks good.


Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>