xfs
[Top] [All Lists]

[PATCH] mkfs: Set a clean output in case of invalid inode size

To: xfs@xxxxxxxxxxx
Subject: [PATCH] mkfs: Set a clean output in case of invalid inode size
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Mon, 16 Apr 2012 17:56:56 -0300
Cc: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Remove an unnecessary usage() call after a mkfs failure due an invalid inode
size.
A call to usage() at this point confuses the output message which may cause the
user to think it used wrong arguments to mkfs, instead of an invalid inode size.

Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
---
 mkfs/xfs_mkfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 5445b6f..19d4815 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1898,7 +1898,7 @@ _("block size %d cannot be smaller than logical sector 
size %d\n"),
                        fprintf(stderr,
        _("allowable inode size with %d byte blocks is between %d and %d\n"),
                                blocksize, XFS_DINODE_MIN_SIZE, maxsz);
-               usage();
+               exit(1);
        }
 
        /* if lsu or lsunit was specified, automatically use v2 logs */
-- 
1.7.7.6

<Prev in Thread] Current Thread [Next in Thread>