xfs
[Top] [All Lists]

Re: [PATCH 05/10] xfs: do flush inodes from background inode reclaim

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] xfs: do flush inodes from background inode reclaim
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 16 Apr 2012 14:25:11 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327164645.389070852@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164645.389070852@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/27/12 11:44, Christoph Hellwig wrote:
We already flush dirty inodes throug the AIL regularly, there is no reason
to have second thread compete with it and disturb the I/O pattern.  We still
do write inodes when doing a synchronous reclaim from the shrinker or during
unmount for now.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

---

-        */
-       return 0;
+       xfs_iflock(ip);

  reclaim:
        xfs_ifunlock(ip);

Is this flush lock / flush unlock cycle needed?

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>