[Top] [All Lists]

Re: [PATCH 02/18 V2] xfs: pass shutdown method into xfs_trans_ail_delete

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/18 V2] xfs: pass shutdown method into xfs_trans_ail_delete_bulk
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 16 Apr 2012 13:49:23 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120413233825.GT6734@dastard>
References: <1334319061-12968-1-git-send-email-david@xxxxxxxxxxxxx> <1334319061-12968-3-git-send-email-david@xxxxxxxxxxxxx> <4F88651E.2030908@xxxxxxx> <20120413230451.GS6734@dastard> <20120413233825.GT6734@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/13/12 18:38, Dave Chinner wrote:
On Sat, Apr 14, 2012 at 09:04:51AM +1000, Dave Chinner wrote:
On Fri, Apr 13, 2012 at 12:40:46PM -0500, Mark Tinguely wrote:
On 04/13/12 07:10, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

xfs_trans_ail_delete_bulk() can be called from different contexts so
if the item is not in the AIL we need different shutdown for each
context.  Pass in the shutdown method needed so the correct action
can be taken.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig<hch@xxxxxx>
Reviewed-by: Mark Tinguely<tinguely@xxxxxxx>

These items in my copy of Christoph's xfsbufd series are not
resolved in this patch:

Ah, oh, that's my fault. I re-ordered the series so that all my
patches were after christoph's, and when reapplying christophs
patches from my series there were a few merge conflicts I obviously
didn't resolve correctly.

I'll fix my tree up and repost this patch.

Updated patch below.

Applies cleanly. Thanks.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>