xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: Introduce test case 285 to check statfs(2) will

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: Introduce test case 285 to check statfs(2) will not cause ASSERT(XFS_IS_QUOTA_RUNNING(mp)) failed.
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 16 Apr 2012 12:49:29 -0500
Cc: xfs@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <4F87ED3D.5060105@xxxxxxxxxx>
References: <4F87ED3D.5060105@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Jeff,

On Fri, Apr 13, 2012 at 05:09:17PM +0800, Jeff Liu wrote:
> Call statfs(2) against a project directory cause 
> ASSERT(XFS_IS_QUOTA_RUNNING(mp)) at xfs_qm_dqget() failed pre-vanilla 
> kernel-3.4
> if the "pquota" or "prjquota" mount option was not enabled on the underlying 
> partition.  This test case can help checking it.

A nice find.

> +echo "Silence is golden."
> +
> +# Modify as appropriate.
> +_supported_fs xfs
> +_supported_os Linux
> +_require_xfs_quota
> +_require_scratch
> +
> +proj_dir="${SCRATCH_MNT}/test_project"
> +test_file="${proj_dir}/test_file"
> +
> +_scratch_mkfs_xfs                    >/dev/null 2>&1
> +_qmount
> +
> +mkdir $proj_dir
> +touch $test_file
> +
> +$XFS_QUOTA_PROG -x -c "project -s -p ${proj_dir} 2012" $SCRATCH_DEV \
> +                                     >/dev/null 2>&1
> +du -sh $proj_dir                     >/dev/null 2>&1

I was unable to reproduce this until I changed 'du -sh' to 'df'.  Now it does
crash consistently without your fix for xfs_fs_statfs().

With that change you can consider this
Reviewed-by: Ben Myers <bpm@xxxxxxx>

-Ben

<Prev in Thread] Current Thread [Next in Thread>