Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm

xfs

Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Fri, 13 Apr 2012 20:33:38 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120327164646.158577302@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164646.158577302@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Mar 27, 2012 at 12:44:07PM -0400, Christoph Hellwig wrote:
> Instead of writing the buffer directly from inside xfs_qm_dqflush return it
> to the caller and let the caller decide what to do with the buffer.  Also
> remove the pincount check in xfs_qm_dqflush that all non-blocking callers
> already implement and the now unused flags parameter and the XFS_DQ_IS_DIRTY
> check that all callers already perform.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks ok.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush, Dave Chinner <= Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush, Mark Tinguely

Previous by Date:	Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Dave Chinner
Next by Date:	Re: [PATCH 08/10] xfs: do not add buffers to the delwri queue until pushed, Dave Chinner
Previous by Thread:	Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Dave Chinner
Next by Thread:	Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush, Mark Tinguely
Indexes:	[Date] [Thread] [Top] [All Lists]