| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Apr 2012 20:31:30 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120327164645.870931834@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164645.870931834@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 27, 2012 at 12:44:06PM -0400, Christoph Hellwig wrote: > Instead of writing the buffer directly from inside xfs_iflush return it to > the caller and let the caller decide what to do with the buffer. Also > remove the pincount check in xfs_iflush that all non-blocking callers already > implement and the now unused flags parameter. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] xfstests: sync before umount to avoid device busy problems, Stefan Behrens |
|---|---|
| Next by Date: | Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush, Dave Chinner |
| Previous by Thread: | Re: [PATCH 05/10] xfs: do flush inodes from background inode reclaim, Dave Chinner |
| Next by Thread: | Re: [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |