xfs
[Top] [All Lists]

Re: [PATCH] disable tags in post-receive hook

To: Russell Cattelan <cattelan@xxxxxxxxxxx>
Subject: Re: [PATCH] disable tags in post-receive hook
From: Stan Hoeppner <stan@xxxxxxxxxxxxxxxxx>
Date: Thu, 12 Apr 2012 21:45:24 -0500
Cc: xfs@xxxxxxxxxxx, Brent Bice <bbice@xxxxxxx>
In-reply-to: <4F86FFAC.6030904@xxxxxxxxxxx>
References: <20120411162627.GJ1802@xxxxxxx> <4F86971A.1030507@xxxxxxxxxxxxxxxxx> <4F86FFAC.6030904@xxxxxxxxxxx>
Reply-to: stan@xxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1
On 4/12/2012 11:15 AM, Russell Cattelan wrote:
> On 4/12/12 3:49 AM, Stan Hoeppner wrote:
>> On 4/11/2012 11:26 AM, Ben Myers wrote:
>>> Hey Folks,
>>>
>>>     Yesterday I pushed tags to the oss.sgi.com xfs git repository and 
>>> forgot to
>>>     disable the post-receive hook which generates email to the list at 
>>> commit
>>>     time.  You probably saw the resulting mailbomb.  I'm sorry about that.  
>>> In
>>>     order to make sure it doesn't happen again next time, I have applied the
>>>     following patch to our post-receive hook:
>>
>> I curse you for the error Ben and praise you for this correction.
>> Mailman unsubbed me sometime yesterday according to a subject line.
>> There was no body, no reason give.  But, I know the cause.
>>
>> I was limiting concurrent SMTP connections to 1 to fight runaway bots.
>> Was working great until this bombing run.  The OSS list server runs
>> Sendmail, which is dumb and opens a new connection for every message
>> delivery.  This behavior can potentially bring an MX to its knees due to
>> smtpd process starvation.
> Hmm yes and no.
> There was some config issues with with queues on oss that hopefully I
> have significantly improved. Sendmail does do connection caching and
> will deliver as much mail as possible on the same connection as
> possible. The problem was that the queue runnners was set to 400 runners
> which was essentially was causing oss to grind itself into the ground
> and causing enough delays that most connection caches where probably
> timing out.

I don't use Sendmail so my apologies if I mischaracterized its
features/behavior.  I was merely describing what I was seeing here.  It
seems that description may have been helpful in troubleshooting/tuning
this, and in the end that's what counts.

> Also the queue sorting has been changed from the default "priority" sort
> which basically will be a time sort in this case to "host" sort which
> will try to optimize envelope address delivery. For a mail list server
> this should be a significant win since it should be able to better take
> advantage of the connection cache. (especially when "tag" bombs happen).

Awesome.

> The queue run time has been changed from the default of 30m to 1m which
> should cut the mail list delays down significantly.

Times two.

> Changed the drive queue scheduler from cfq to deadline

And again.

> I've been watching the headers since the change and the turn around
> times for mail leaving the originating host to landing in my mail server
> is about 1 - 2 min. Occasionally there is a delay on sgi's barracuda box
> but that is whole other box of worms.

Anything under 5 minutes, regardless of where any delays are occurring,
seems acceptable in my book, and much better than the previous setup.

> Please send me any observations  + or - so I know if the tuning is
> headed in the right direction.

I sure will Russel.  A short while back when problems hit a threshold
here, I searched the whois records for the appropriate contact and went
from there, ended up working with Brent, who was eager to help if he
could, but made it clear the list had another responsible party/owner.
I guess that would be you. :)

Apologies if I've inadvertently stepped on anyone's toes, asked anyone
to employ a can opener against his will.  I just wanted to bring some
long standing issues to attention and hopefully get them resolved.  It
appears that has happened.

Thanks for addressing these issues Russel.  I'm sure others will be
pleased by your efforts here as well.  Whether the MTA is Sendmail or
Postfix is irrelevant as long as it works properly.

Thanks again.

-- 
Stan

<Prev in Thread] Current Thread [Next in Thread>