xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: kill XBF_LOCK

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfs: kill XBF_LOCK
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 12 Apr 2012 08:23:56 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120411200729.GJ28816@xxxxxxxxxxxxx>
References: <1334052213-26870-1-git-send-email-david@xxxxxxxxxxxxx> <1334052213-26870-2-git-send-email-david@xxxxxxxxxxxxx> <4F844B02.2030301@xxxxxxx> <20120410222027.GR18323@dastard> <20120411200729.GJ28816@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/11/12 15:07, Christoph Hellwig wrote:
On Wed, Apr 11, 2012 at 08:20:27AM +1000, Dave Chinner wrote:
The reason I ask, the sources that I have for xfs_buf_get() seems to
still have a "goto no_buffer" for the failed
xfs_buf_allocate_memory() call and this patch removes that call. I
did not find anything in the 8 buf clean-up series that would alter
this area.

I'm sure I posted it previously. Let me update all the reviewed-by
tags and I'll resend the entire series....

I think Mark meant the patch to fix the error handling for failed
allocation, which needs to be redone to only insert the buffer into the
rbtree once it's fully set up.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

That is correct.

The series in general looked good to me.

--Mark Tinguely.

<Prev in Thread] Current Thread [Next in Thread>