[Top] [All Lists]

Re: [PATCH 1/3] xfs: kill XBF_LOCK

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfs: kill XBF_LOCK
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 12 Apr 2012 08:51:32 +1000
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120411200729.GJ28816@xxxxxxxxxxxxx>
References: <1334052213-26870-1-git-send-email-david@xxxxxxxxxxxxx> <1334052213-26870-2-git-send-email-david@xxxxxxxxxxxxx> <4F844B02.2030301@xxxxxxx> <20120410222027.GR18323@dastard> <20120411200729.GJ28816@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 11, 2012 at 04:07:29PM -0400, Christoph Hellwig wrote:
> On Wed, Apr 11, 2012 at 08:20:27AM +1000, Dave Chinner wrote:
> > > The reason I ask, the sources that I have for xfs_buf_get() seems to
> > > still have a "goto no_buffer" for the failed
> > > xfs_buf_allocate_memory() call and this patch removes that call. I
> > > did not find anything in the 8 buf clean-up series that would alter
> > > this area.
> > 
> > I'm sure I posted it previously. Let me update all the reviewed-by
> > tags and I'll resend the entire series....
> I think Mark meant the patch to fix the error handling for failed
> allocation, which needs to be redone to only insert the buffer into the
> rbtree once it's fully set up.

Right. What I meant was that I need to resend the entire 12-13
buffer cache patches I have in my queue right now so that they
should all apply easily...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>