xfs
[Top] [All Lists]

Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set
From: Bryan Schumaker <bjschuma@xxxxxxxxxx>
Date: Wed, 11 Apr 2012 16:10:12 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120411200433.GE28816@xxxxxxxxxxxxx>
References: <4F832C25.3080408@xxxxxxxxxx> <20120409214445.GJ18323@dastard> <20120411200433.GE28816@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120406 Thunderbird/11.0.1
On 04/11/12 16:04, Christoph Hellwig wrote:

> On Tue, Apr 10, 2012 at 07:44:45AM +1000, Dave Chinner wrote:
>> On Mon, Apr 09, 2012 at 02:36:21PM -0400, Bryan Schumaker wrote:
>>> The cleanup function is trapped before _require_scratch() is called, and
>>> then expands "rm -rf $SCRATCH_MNT/*" to "rm -rf /*"
>>
>> It doesn't need to clean up the scratch device - tests need to mkfs
>> it first before using it, so just remove the $tmp* files. The sae
>> fix is needed for tests 274 and 275.
> 
> Given his address I assume Bryan might test on NFS, which has funky
> semantics for the scratch device.
> 
> Is that true Bryan?  I really need to dive back into how we handle NFS
> in this respect to have a good judgement on this patch.
> 


Yeah, I'm testing on NFS (I guess the netapp address is a bit of a 
giveaway...).  I don't think this test runs on NFS, but if the scratch 
variables are unset then it'll still delete the root directory of the NFS 
client.

- Bryan

<Prev in Thread] Current Thread [Next in Thread>