| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/3] xfs: kill XBF_LOCK |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 11 Apr 2012 16:07:29 -0400 |
| Cc: | Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20120410222027.GR18323@dastard> |
| References: | <1334052213-26870-1-git-send-email-david@xxxxxxxxxxxxx> <1334052213-26870-2-git-send-email-david@xxxxxxxxxxxxx> <4F844B02.2030301@xxxxxxx> <20120410222027.GR18323@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Apr 11, 2012 at 08:20:27AM +1000, Dave Chinner wrote: > > The reason I ask, the sources that I have for xfs_buf_get() seems to > > still have a "goto no_buffer" for the failed > > xfs_buf_allocate_memory() call and this patch removes that call. I > > did not find anything in the 8 buf clean-up series that would alter > > this area. > > I'm sure I posted it previously. Let me update all the reviewed-by > tags and I'll resend the entire series.... I think Mark meant the patch to fix the error handling for failed allocation, which needs to be redone to only insert the buffer into the rbtree once it's fully set up. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/3] xfs: kill XBF_DONTBLOCK, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 0/3] xfs: More xfs_buf cleanups, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/3] xfs: kill XBF_LOCK, Dave Chinner |
| Next by Thread: | Re: [PATCH 1/3] xfs: kill XBF_LOCK, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |