xfs
[Top] [All Lists]

Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Apr 2012 16:04:33 -0400
Cc: Bryan Schumaker <bjschuma@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120409214445.GJ18323@dastard>
References: <4F832C25.3080408@xxxxxxxxxx> <20120409214445.GJ18323@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 10, 2012 at 07:44:45AM +1000, Dave Chinner wrote:
> On Mon, Apr 09, 2012 at 02:36:21PM -0400, Bryan Schumaker wrote:
> > The cleanup function is trapped before _require_scratch() is called, and
> > then expands "rm -rf $SCRATCH_MNT/*" to "rm -rf /*"
> 
> It doesn't need to clean up the scratch device - tests need to mkfs
> it first before using it, so just remove the $tmp* files. The sae
> fix is needed for tests 274 and 275.

Given his address I assume Bryan might test on NFS, which has funky
semantics for the scratch device.

Is that true Bryan?  I really need to dive back into how we handle NFS
in this respect to have a good judgement on this patch.

<Prev in Thread] Current Thread [Next in Thread>