| To: | Bryan Schumaker <bjschuma@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 10 Apr 2012 07:44:45 +1000 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <4F832C25.3080408@xxxxxxxxxx> |
| References: | <4F832C25.3080408@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 09, 2012 at 02:36:21PM -0400, Bryan Schumaker wrote: > The cleanup function is trapped before _require_scratch() is called, and > then expands "rm -rf $SCRATCH_MNT/*" to "rm -rf /*" It doesn't need to clean up the scratch device - tests need to mkfs it first before using it, so just remove the $tmp* files. The sae fix is needed for tests 274 and 275. Also, it shouldn't be using "-rf" to do cleanup - "rm -f $tmp.*" is sufficient to remove all the tmp files... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: detecting case-insensitivity, J. Bruce Fields |
|---|---|
| Next by Date: | Re: XFS: Abysmal write performance because of excessive seeking (allocation groups to blame?), Dave Chinner |
| Previous by Thread: | [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set, Bryan Schumaker |
| Next by Thread: | Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set, Bryan Schumaker |
| Indexes: | [Date] [Thread] [Top] [All Lists] |