xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: several 274 fixups

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: several 274 fixups
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Apr 2012 11:12:08 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4F593147.8050603@xxxxxxxxxxx>
References: <4F271967.10308@xxxxxxxxxxx> <4F593147.8050603@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/08/12 16:23, Eric Sandeen wrote:
This changes quite a few things about 274 to make it more robust
and useful.

* More comments
* Use xfs_io for falloc (not all systems have /usr/bin/fallocate)
* use _require_xfs_io_falloc to be sure system&  fs support preallocation
* Do not remove all of the files in $SCRATCH_MNT/ post-mkfs
* Do not remove all of the files in $SCRATCH_MNT/ on completion
   (this breaks e2fsck when lost+found/ goes missing)
* Don't cd into $SCRATCH_MNT
* Try harder to completely fill the fs
* Use a larger preallocated space, and write into all of it (hopefully
   avoid just accidentally succeeding by writing into fs reserved
   space that may be there)
* Save more output in $seq.full instead of /dev/null
* Fill preallocated space diabolically

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

Looks very nice.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH V2] xfstests: several 274 fixups, Mark Tinguely <=