xfs
[Top] [All Lists]

Re: [PATCH] xfs: don't fill statvfs with project quota for a directory i

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled.
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Wed, 04 Apr 2012 11:48:22 -0500
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
In-reply-to: <20120402163903.GA6425@xxxxxxxxxxxxx>
Organization: IBM
References: <4F77DFDB.1040802@xxxxxxxxxx> <20120402163903.GA6425@xxxxxxxxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
I tried the steps in latest xfs tree and on mainline 3.3.0. Unable to
reproduce the problem.

Jeff, how big was the FS and how full was it ?

Christoph, BTW, 3.3.0 does not have my changes. Ben pushed it for
3.4-rc1

Here is my results with 3.3.0
-------------------
-bash-4.1$ uname -r
3.3.0 
bash-4.1$  mount | grep xfs
/dev/sdb1 on /xfs type xfs (rw)
bash-4.1$ cat /etc/projects
1:/xfs
bash-4.1$ cat /etc/projid
project1:1
bash-4.1$ sudo xfs_quota -x -c 'project -s project1' /xfs
[sudo] password for chandra: 
Setting up project project1 (path /xfs)...
Processed 1 (/etc/projects and cmdline) paths for project project1 with
recursion depth infinite (-1).
bash-4.1$ du -sh /xfs
0       /xfs
bash-4.1$ exit
------------------

Chandra

On Mon, 2012-04-02 at 12:39 -0400, Christoph Hellwig wrote:
> On Sun, Apr 01, 2012 at 12:55:55PM +0800, Jeff Liu wrote:
> > Hello,
> > 
> > I can trigger a BUG() at fs/xfs/xfs_dquot.c on vanilla kernel 3.3.0 by the 
> > following steps:
> > 
> > 1. mount a XFS partition without 'pquota' option.
> >    /dev/sda7 on /xfs type xfs (rw)
> > 
> > 2. setup project1 on it.
> >    $ cat /etc/projects 
> >    1:/xfs
> >    $ cat /etc/projid
> >    project1:1
> >    $ sudo xfs_quota -x -c 'project -s project1' /xfs
> > 
> > 3. du -sh /xfs
> 
> Can you wire this up as a test case for xfstests?
> 
> > +               ((mp->m_qflags & (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))) ==
> > +                (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD)) {
> 
> This check is supposed to return false.  I guess Chandras separate
> project quota inode preparations somehow broke it.
> 
> Chandra, can you look into this issue?
> 


<Prev in Thread] Current Thread [Next in Thread>