xfs
[Top] [All Lists]

Re: [PATCH] xfs: don't fill statvfs with project quota for a directory i

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled.
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 04 Apr 2012 16:02:41 +0800
Cc: Ben Myers <bpm@xxxxxxx>, Chandra Seetharaman <sekharan@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120402163903.GA6425@xxxxxxxxxxxxx>
Organization: Oracle
References: <4F77DFDB.1040802@xxxxxxxxxx> <20120402163903.GA6425@xxxxxxxxxxxxx>
Reply-to: jeff.liu@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
On 04/03/2012 12:39 AM, Christoph Hellwig wrote:

> On Sun, Apr 01, 2012 at 12:55:55PM +0800, Jeff Liu wrote:
>> Hello,
>>
>> I can trigger a BUG() at fs/xfs/xfs_dquot.c on vanilla kernel 3.3.0 by the 
>> following steps:
>>
>> 1. mount a XFS partition without 'pquota' option.
>>    /dev/sda7 on /xfs type xfs (rw)
>>
>> 2. setup project1 on it.
>>    $ cat /etc/projects 
>>    1:/xfs
>>    $ cat /etc/projid
>>    project1:1
>>    $ sudo xfs_quota -x -c 'project -s project1' /xfs
>>
>> 3. du -sh /xfs
> 
> Can you wire this up as a test case for xfstests?

Ok, I'll work it out.

Thanks,
-Jeff

> 
>> +                ((mp->m_qflags & (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))) ==
>> +                 (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD)) {
> 
> This check is supposed to return false.  I guess Chandras separate
> project quota inode preparations somehow broke it.
> 
> Chandra, can you look into this issue?
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>