xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: reduce ilock hold times in xfs_setattr_size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: reduce ilock hold times in xfs_setattr_size
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 02 Apr 2012 14:26:33 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327143826.615954651@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120327143445.196524266@xxxxxxxxxxxxxxxxxxxxxx> <20120327143826.615954651@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/27/12 09:34, Christoph Hellwig wrote:
We do not need the ilock for most checks done in the beginning of
xfs_setattr_size.  Replace the long critical section before starting the
transaction with a smaller one around xfs_zero_eof and an optional one
inside xfs_qm_dqattach that isn't entered unless using quotas.  While
this isn't a big optimization for xfs_setattr_size itself it will allow
pushing the ilock into xfs_zero_eof itself later.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>