[Top] [All Lists]

Re: [PATCH 2/5] xfs: reduce ilock hold times in xfs_file_aio_write_check

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: reduce ilock hold times in xfs_file_aio_write_checks
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 02 Apr 2012 14:26:11 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327143826.433267717@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120327143445.196524266@xxxxxxxxxxxxxxxxxxxxxx> <20120327143826.433267717@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/27/12 09:34, Christoph Hellwig wrote:
We do not need the ilock for generic_write_checks and the i_size read,
which are protected by i_mutex and/or iolock, so reduce the ilock
critical section to just the call to xfs_zero_eof.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>