xfs
[Top] [All Lists]

Re: [PATCH 3/7] gfs2: Use generic handlers of O_SYNC AIO DIO

To: Jeff Moyer <jmoyer@xxxxxxxxxx>
Subject: Re: [PATCH 3/7] gfs2: Use generic handlers of O_SYNC AIO DIO
From: Steven Whitehouse <swhiteho@xxxxxxxxxx>
Date: Mon, 02 Apr 2012 15:29:31 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jack@xxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <1333058705-31512-4-git-send-email-jmoyer@xxxxxxxxxx>
Organization: Red Hat UK Ltd
References: <1333058705-31512-1-git-send-email-jmoyer@xxxxxxxxxx> <1333058705-31512-4-git-send-email-jmoyer@xxxxxxxxxx>
Hi,

On Thu, 2012-03-29 at 18:05 -0400, Jeff Moyer wrote:
> From: Jan Kara <jack@xxxxxxx>
> 
> Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
> file.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
Acked-by: Steven Whitehouse <swhiteho@xxxxxxxxxx>

Steve.

> ---
>  fs/gfs2/aops.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index 38b7a74..2589781 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -1034,7 +1034,7 @@ static ssize_t gfs2_direct_IO(int rw, struct kiocb 
> *iocb,
>  
>       rv = __blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov,
>                                 offset, nr_segs, gfs2_get_block_direct,
> -                               NULL, NULL, 0);
> +                               NULL, NULL, DIO_SYNC_WRITES);
>  out:
>       gfs2_glock_dq_m(1, &gh);
>       gfs2_holder_uninit(&gh);


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 3/7] gfs2: Use generic handlers of O_SYNC AIO DIO, Steven Whitehouse <=