xfs
[Top] [All Lists]

Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 31 Mar 2012 11:39:35 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4F75DE2B.7030807@xxxxxxxxxx>
References: <4F75DE2B.7030807@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 30, 2012 at 11:24:11AM -0500, Eric Sandeen wrote:
> This ASSERT is testing an if_flags flag value against
> a di_aformat enum value.  di_aformat is never assigned
> XFS_IFINLINE.
> 
> This happens to work for now, because XFS_IFINLINE has
> the same value as XFS_DINODE_FMT_LOCAL, and that's tested
> just before we call this function.
> 
> However, I think the intention is to assert that we have
> read in the data, i.e. XFS_IFINLINE on if_flags, before
> we use if_data.  This is done in other places through the
> code as well.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>