| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/8] xfs: kill b_file_offset |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Fri, 30 Mar 2012 14:12:40 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1333023835-12856-6-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1333023835-12856-1-git-send-email-david@xxxxxxxxxxxxx> <1333023835-12856-6-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 03/29/12 07:23, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> Seeing as we pass block numbers around everywhere in the buffer cache now, it makes no sense to index everything by byte offset. Replace all the byte offset indexing with block number based indexing, and replace all uses of the byte offset with direct conversion from the block index. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> Reviewed-by: Christoph Hellwig<hch@xxxxxx> --- Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| Previous by Date: | Re: [PATCH 4/8] xfs: clean up buffer get/read call API, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 6/8] xfs: use blocks for counting length of buffers, Mark Tinguely |
| Previous by Thread: | [PATCH 5/8] xfs: kill b_file_offset, Dave Chinner |
| Next by Thread: | [PATCH 4/8] xfs: clean up buffer get/read call API, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |