xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: check for buffer errors before waiting

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: check for buffer errors before waiting
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 30 Mar 2012 08:17:41 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120329191203.GB8622@xxxxxxxxxxxxx>
References: <1333023835-12856-1-git-send-email-david@xxxxxxxxxxxxx> <1333023835-12856-2-git-send-email-david@xxxxxxxxxxxxx> <20120329191203.GB8622@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 29, 2012 at 03:12:03PM -0400, Christoph Hellwig wrote:
> The actual fix looks good:
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> But shou;dn't we move the setting of b_error to zero into common buffer
> code instead of adding it to the callers?

We generally do - in xfs_buf_iodone_callbacks() - which covers
pretty much all cached buffer IO.

However, for uncached buffers, it is only zeroed in xfs_buf_alloc().
For single use buffers, this is fine, but for multiple use buffers
like the log uses during recovery for log IO, it doesn't get reset
anywhere because the buffer doesn't go anywhere near common buffer
code between IOs.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>