xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix buffer lookup race on allocation failure

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix buffer lookup race on allocation failure
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 30 Mar 2012 08:04:49 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120329190759.GA8622@xxxxxxxxxxxxx>
References: <1333022846-12697-1-git-send-email-david@xxxxxxxxxxxxx> <20120329190759.GA8622@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 29, 2012 at 03:07:59PM -0400, Christoph Hellwig wrote:
> I don't like this solution.  What speaks against building up the page
> array after the first buffer lookup failed, but before linking the
> buffer into the rbtree? That's the the inode cache and all the VFS
> caches do.

That could be done, I think. I always wondered why it was done after
insert, but never knew the reason so I didn't change the logic. I'll
respin it and see what happens.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>