| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: fix buffer lookup race on allocation failure |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 29 Mar 2012 15:07:59 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1333022846-12697-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1333022846-12697-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
I don't like this solution. What speaks against building up the page array after the first buffer lookup failed, but before linking the buffer into the rbtree? That's the the inode cache and all the VFS caches do. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/8] xfs: check for buffer errors before waiting, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 1/8] xfs: check for buffer errors before waiting, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs: fix buffer lookup race on allocation failure, Mark Tinguely |
| Next by Thread: | Re: [PATCH] xfs: fix buffer lookup race on allocation failure, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |