xfs
[Top] [All Lists]

Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 27 Mar 2012 13:17:30 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327164644.243162639@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164644.243162639@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/27/12 11:44, Christoph Hellwig wrote:
If a filesystem has been forced shutdown we are never going to write dquots
to disk, which means the dquot items will stay in the AIL forever.
Currently that is not a problem, but a pending chance requires us to
empty the AIL before shutting down the filesystem, in which case this
behaviour is lethal.  Make sure to remove the log item from the AIL
to allow emptying the AIL on shutdown filesystems.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>