xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: push the ilock into xfs_zero_eof

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs: push the ilock into xfs_zero_eof
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 27 Mar 2012 17:11:29 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120327054827.GA11976@xxxxxxxxxxxxx>
References: <20120326211421.518374058@xxxxxxxxxxxxxxxxxxxxxx> <20120326211603.654869525@xxxxxxxxxxxxxxxxxxxxxx> <20120327011540.GS5091@dastard> <20120327054827.GA11976@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 27, 2012 at 01:48:27AM -0400, Christoph Hellwig wrote:
> On Tue, Mar 27, 2012 at 12:15:40PM +1100, Dave Chinner wrote:
> > > + xfs_ilock(ip, XFS_ILOCK_EXCL);
> > >   error = xfs_bmapi_read(ip, last_fsb, 1, &imap, &nimaps, 0);
> > > + xfs_iunlock(ip, XFS_ILOCK_EXCL);
> > 
> > Does that even need to be an exclusive lock? a shared lock is all
> > that is needed to do a lookup, and this is just a lookup...
> 
> It has to be a xfs_ilock_map_shared - but given that we hold the iolock
> exclusive anyway I didn't bother to optimize this further.

Ok, makes sense.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>