xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: reduce ilock hold times in xfs_setattr_size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: reduce ilock hold times in xfs_setattr_size
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 27 Mar 2012 09:17:51 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120326211603.455167123@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120326211421.518374058@xxxxxxxxxxxxxxxxxxxxxx> <20120326211603.455167123@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 26, 2012 at 05:14:24PM -0400, Christoph Hellwig wrote:
> We do not need the ilock for most checks done in the beginning of
> xfs_setattr_size.  Replace the long critical section before starting the
> transaction with a smaller one around xfs_zero_eof and an optional one
> inside xfs_qm_dqattach that isn't entered unless using quotas.  While
> this isn't a big optimization for xfs_setattr_size itself it will allow
> pushing the ilock into xfs_zero_eof itself later.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks sane to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>