[Top] [All Lists]

Re: [PATCH] xfstests 235: do smaller test IO

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests 235: do smaller test IO
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 27 Mar 2012 09:09:26 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Eryu Guan <eguan@xxxxxxxxxx>
In-reply-to: <4F70C3D9.80708@xxxxxxxxxx>
References: <4F70C3D9.80708@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 26, 2012 at 02:30:33PM -0500, Eric Sandeen wrote:
> Test 235 fails on ext2/ext3 with 1024 fs block size because a
> 16k write uses an extra metadata block.  If we do a smaller write
> this won't happen.
> -$XFS_IO_PROG -F -c 'pwrite 0 16k' -c 'fsync' \
> +$XFS_IO_PROG -F -c 'pwrite 0 8k' -c 'fsync' \

So now it fails only on 512 byte block size filesystems?

Perhaps rather than an exact match, a "within_tolerance" match could
be done on the relevant fields?

i.e something like:

blksused=`{requota cmd} | awk '/fsgqa/ { print $3 }'`
_within_tolerance "blocks used" $blksused 16 1

If you wanted to get really fancy, the tolerance could be set
depending on filesystem type and block size, but I don't think that
is really necessary....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>